Fix linux warnings Wformat #8361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
If you anyway touch this code - may be better remove cast to SLONG? |
dyemanov
reviewed
Dec 24, 2024
src/include/fb_types.h
Outdated
| typedef unsigned long ULONG; | ||
| const SLONG SLONG_MIN = LONG_MIN; | ||
| const SLONG SLONG_MAX = LONG_MAX; | ||
| #define SLONG_STR_FORMAT "%ld" |
Member
There was a problem hiding this comment.
We already have SLONGFORMAT defined in common.h, why yet another define?
Contributor
Author
There was a problem hiding this comment.
Thanks for the note. I didn't know.
Contributor
Author
Perhaps it may be better. But the cause of warning was the usage of wrong format. So, I assumed the fix is usage of proper format. |
dyemanov
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.